Send info if model is available together with the model #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
approved these changes
Oct 4, 2024
Comment on lines
+210
to
+213
| export interface ModelAvailabilityStatus { | ||
| model: Model | ||
| isModelAvailable: boolean | ||
| } |
There was a problem hiding this comment.
It is OK but...
We have ModelTags to provide the model's meta-data. And a few values are called "statuses" in the comment.
There was a problem hiding this comment.
We already have model tags in the model.
But that does not solve our issue.
It's ok to know if model is available for free or pro user, but that in itself does not answer the question if current user is pro or free. That is something outside of the model itself.
pkukielka
added a commit
to sourcegraph/jetbrains
that referenced
this pull request
Oct 4, 2024
…#2386) ## Changes Follow-up to sourcegraph/cody#5804 Instead of manually fetching account tier and computing model availability we instead receiving it from agent. This makes code simpler, ensures the same consitions are used by both Cody and JetBrains, and is less error prone. ## Test plan **Free user** 1. Login as free user 2. Open Edit Code popup 3. Ensure models are visible 4. Choose one without `Pro` label and do the edit -> it should success 5. Choose one with `Pro` label and do the edit -> it should open the account upgrade website **Pro use** 1. Login as pro user 2. Open Edit Code popup 3. Ensure models are visible, and there are no `Pro` labels anywhere 4. Choose model which was previously marked as pro on the free tier and do the edit -> it should success **Enterprise user** 1. Login as enterprise user 2. Open Edit Code popup 3. Ensure models are visible, and there are no `Pro` labels anywhere 4. Choose model which was previously marked as pro (if such exists) on the free tier and do the edit -> it should success Attention: This is different than the current behaviour, but I checked Cody and it allows for model selection for the enterprise accounts so I think JetBrains behaviour drifted there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will allow clients to know if model is useable for them with of manually fetching account tier and computing model availability.
This makes client code simpler, ensures the same conditions are used by both Cody and clients, and is less error prone.
Test plan
This is only used in JetBrains currently.
Testplan on the JetBrains side:
sourcegraph/jetbrains#2386