Propagate font settings from JetBrains to webview #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
reviewed
Nov 15, 2024
| val fontSizeVariable = | ||
| (toCSSVariableName("font-size") to "${UISettings.getInstance().fontSize}px") | ||
|
|
||
| return WebTheme(ThemeUtil.isDarkTheme(), colorVariables + fontSizeVariable) |
There was a problem hiding this comment.
What are these variables? Strings of css properties?
There was a problem hiding this comment.
They are used for css substitution here:
https://github.com/sourcegraph/cody/pull/6134/files/d03e45208f6030dc3064c77ec49552caa20b9f60#diff-8765a30f3f70a874222d56f0f4eb9c7380b324d07902ae0227afab7ce7afd4d7
mkondratek
approved these changes
Nov 15, 2024
pkukielka
added a commit
to sourcegraph/cody
that referenced
this pull request
Nov 18, 2024
## Test plan 1. Run this branch with sourcegraph/jetbrains#2654 (using CODY_DIR and `:customRunIde`) 2. In IntelliJ open `Settings > Appearance` 3. Tick `Use custom font` and change font size 4. Apply changes 5. You should notice that both editor and webview font size changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://linear.app/sourcegraph/issue/BUGS-462
https://linear.app/sourcegraph/issue/BUGS-342
https://linear.app/sourcegraph/issue/BUGS-220
Test plan
Use custom fontand change font size