Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Doc encryption with symmetric key #2731

Merged

Code review fixups

8bc56c7
Select commit
Loading
Failed to load commit list.
Merged

feat: Doc encryption with symmetric key #2731

Code review fixups
8bc56c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 4, 2024 in 0s

78.69% (-0.30%) compared to ea77dc2

View this Pull Request on Codecov

78.69% (-0.30%) compared to ea77dc2

Details

Codecov Report

Attention: Patch coverage is 76.28032% with 88 lines in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (ea77dc2) to head (8bc56c7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2731      +/-   ##
===========================================
- Coverage    78.99%   78.69%   -0.30%     
===========================================
  Files          315      318       +3     
  Lines        23873    24128     +255     
===========================================
+ Hits         18858    18987     +129     
- Misses        3649     3772     +123     
- Partials      1366     1369       +3     
Files Coverage Δ
client/document.go 70.50% <ø> (-1.30%) ⬇️
client/request/mutation.go 100.00% <ø> (ø)
datastore/multi.go 92.00% <100.00%> (+1.09%) ⬆️
http/client.go 55.97% <100.00%> (+0.18%) ⬆️
internal/core/block/block.go 90.65% <100.00%> (-0.57%) ⬇️
internal/db/collection.go 72.02% <100.00%> (-0.41%) ⬇️
internal/db/context.go 100.00% <100.00%> (ø)
internal/db/fetcher/fetcher.go 79.18% <100.00%> (-0.63%) ⬇️
internal/db/fetcher/versioned.go 68.46% <100.00%> (ø)
internal/encryption/context.go 100.00% <100.00%> (ø)
... and 24 more

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea77dc2...8bc56c7. Read the comment docs.