-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(i): Bump all gh-action versions to support node20 #2780
Conversation
with: | ||
go-version: "1.21" | ||
go-version-file: 'go.mod' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
info: This is done so we now don't have to manually update the version every time we bump go version. This will detect it from the mod file automatically.
@@ -36,4 +36,4 @@ jobs: | |||
go-version-input: "1.21" | |||
go-package: ./... | |||
check-latest: true | |||
cache: true | |||
cache: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why have you disabled the cache? (all workflows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the built in caching (which uses lock files) to mess up our caches that are stored based on non-lockfiles for the main testing actions. These are quick actions that I don't care much about (to use cache), the main one we care about shouldn't miss caches because some other action cached a lock-file based one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another note: The places I added cache: false
to where it didn't exist is because since the upgrade to the new version the default was changed to cache: true
.
64b2693
to
24456da
Compare
24456da
to
e6724b4
Compare
e6724b4
to
008d149
Compare
008d149
to
e7d7573
Compare
e7d7573
to
6ad940c
Compare
6ad940c
to
5df464f
Compare
5df464f
to
1f3731a
Compare
1f3731a
to
7574204
Compare
7574204
to
9af6a39
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2780 +/- ##
===========================================
+ Coverage 78.73% 78.87% +0.14%
===========================================
Files 315 315
Lines 23835 23835
===========================================
+ Hits 18766 18799 +33
+ Misses 3685 3663 -22
+ Partials 1384 1373 -11
Flags with carried forward coverage won't be shown. Click here to find out more. see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
9af6a39
to
2d26ed7
Compare
_${{ matrix.database-type }}\ | ||
_${{ matrix.mutation-type }}\ | ||
_${{ matrix.lens-type }}\ | ||
_${{ matrix.database-encryption }}\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: don't need the change detection
label here as we don't generate any coverage reports in that step, also in a follow-up PR will remove the change detection step in it's own workflow so that we no longer have to wait for code-cov uploading to be blocked on the change detection step which takes 5ish minutes more.
2d26ed7
to
caded6b
Compare
caded6b
to
563618e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
563618e
to
0029fcf
Compare
Terraform Format and Style
|
Relevant issue(s)
Resolves #2778
Description
node20
versionsGo Releaser
How has this been tested?
act
toolSpecify the platform(s) on which this was tested: