Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(i): Bump all gh-action versions to support node20 #2780

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jun 25, 2024

Relevant issue(s)

Resolves #2778

Description

  • Similar to ci: Bump all gh-action versions to support node16 #990
  • Update all actions to node20 versions
  • There was a bug the way we were using artifacts previously such that it would overwrite some generated code coverage reports due to artifact name clashing, this was caught as the behavior of "artifact name clashing" now causes error instead of "merging" them. The fix is in the last commit, which will now ensure "more" accurate coverage as the missing 3 reports are also included.

Go Releaser

How has this been tested?

  • act tool
  • ci

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. deprecate Indicates something is deprecated. labels Jun 25, 2024
@shahzadlone shahzadlone added this to the DefraDB v0.12 milestone Jun 25, 2024
@shahzadlone shahzadlone requested a review from a team June 25, 2024 21:20
@shahzadlone shahzadlone self-assigned this Jun 25, 2024
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
with:
go-version: "1.21"
go-version-file: 'go.mod'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info: This is done so we now don't have to manually update the version every time we bump go version. This will detect it from the mod file automatically.

@@ -36,4 +36,4 @@ jobs:
go-version-input: "1.21"
go-package: ./...
check-latest: true
cache: true
cache: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why have you disabled the cache? (all workflows)

Copy link
Member Author

@shahzadlone shahzadlone Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want the built in caching (which uses lock files) to mess up our caches that are stored based on non-lockfiles for the main testing actions. These are quick actions that I don't care much about (to use cache), the main one we care about shouldn't miss caches because some other action cached a lock-file based one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note: The places I added cache: false to where it didn't exist is because since the upgrade to the new version the default was changed to cache: true.

@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 64b2693 to 24456da Compare June 25, 2024 22:44
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 24456da to e6724b4 Compare June 25, 2024 23:00
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from e6724b4 to 008d149 Compare June 25, 2024 23:22
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 008d149 to e7d7573 Compare June 25, 2024 23:39
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 25, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from e7d7573 to 6ad940c Compare June 25, 2024 23:58
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 26, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 6ad940c to 5df464f Compare June 26, 2024 00:15
@sourcenetwork sourcenetwork deleted a comment from codecov bot Jun 26, 2024
@sourcenetwork sourcenetwork deleted a comment from codecov bot Jun 26, 2024
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 26, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 5df464f to 1f3731a Compare June 26, 2024 00:32
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 26, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 1f3731a to 7574204 Compare June 27, 2024 11:02
@sourcenetwork sourcenetwork deleted a comment from codecov bot Jun 27, 2024
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 7574204 to 9af6a39 Compare June 27, 2024 11:20
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 27, 2024
@sourcenetwork sourcenetwork deleted a comment from codecov bot Jun 27, 2024
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (1a8b1fa) to head (0029fcf).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2780      +/-   ##
===========================================
+ Coverage    78.73%   78.87%   +0.14%     
===========================================
  Files          315      315              
  Lines        23835    23835              
===========================================
+ Hits         18766    18799      +33     
+ Misses        3685     3663      -22     
+ Partials      1384     1373      -11     
Flag Coverage Δ
all-tests 78.87% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8b1fa...0029fcf. Read the comment docs.

@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 9af6a39 to 2d26ed7 Compare June 27, 2024 11:21
_${{ matrix.database-type }}\
_${{ matrix.mutation-type }}\
_${{ matrix.lens-type }}\
_${{ matrix.database-encryption }}\
Copy link
Member Author

@shahzadlone shahzadlone Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: don't need the change detection label here as we don't generate any coverage reports in that step, also in a follow-up PR will remove the change detection step in it's own workflow so that we no longer have to wait for code-cov uploading to be blocked on the change detection step which takes 5ish minutes more.

@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 2d26ed7 to caded6b Compare June 27, 2024 11:41
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 27, 2024
@shahzadlone shahzadlone requested a review from a team June 27, 2024 12:22
@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from caded6b to 563618e Compare June 27, 2024 20:21
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 27, 2024
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/bump/ci-actions-to-node20 branch from 563618e to 0029fcf Compare June 27, 2024 21:36
@source-devs
Copy link

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Terraform Plan success

Show Plan

Terraform Plan Output:
data.aws_ami.ami: Reading...
aws_security_group.sg: Refreshing state... [id=sg-03ba6f1f9cd118f43]
data.aws_ami.ami: Read complete after 1s [id=ami-0b436d9dc6b1762be]
aws_instance.instance: Refreshing state... [id=i-087b6a34e288d739d]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.


Pushed By: @shahzadlone
SHA: 0029fcff8cfa917c7a143a57b50e59a8633f69a6

@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 27, 2024
@shahzadlone shahzadlone merged commit 343ec38 into develop Jun 27, 2024
41 of 42 checks passed
@shahzadlone shahzadlone deleted the lone/bump/ci-actions-to-node20 branch June 27, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it. deprecate Indicates something is deprecated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all actions to Node20 instead of Node16
4 participants