Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i): Bump & fix the breaking change of libp2p dep #2791

Merged

Conversation

shahzadlone
Copy link
Member

Description

  • Fix some broken deps

How has this been tested?

ci

Specify the platform(s) on which this was tested:

  • WSL2

@shahzadlone shahzadlone added dependencies Related to dependencies deprecate Indicates something is deprecated. bump Bumped version for something labels Jun 28, 2024
@shahzadlone shahzadlone self-assigned this Jun 28, 2024
@shahzadlone shahzadlone changed the title chore(i): Bump & fix the breaking change of libp2p/ dep chore(i): Bump & fix the breaking change of libp2p dep Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (aaaa9d9) to head (002a1f4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2791      +/-   ##
===========================================
- Coverage    78.81%   78.72%   -0.10%     
===========================================
  Files          315      315              
  Lines        23836    23836              
===========================================
- Hits         18786    18763      -23     
- Misses        3672     3690      +18     
- Partials      1378     1383       +5     
Flag Coverage Δ
all-tests 78.72% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaaa9d9...002a1f4. Read the comment docs.

@shahzadlone shahzadlone requested a review from a team June 28, 2024 03:05
@fredcarle
Copy link
Collaborator

What would you say was a breaking change about this? It seems that only the go.mod file was changed.

@shahzadlone
Copy link
Member Author

The independent dependencies broke due to their breaking changes. If you look at the dependabot PRs that are failing, it's because of that. This change fixes those "broken dep changes"

@shahzadlone shahzadlone added this to the DefraDB v0.13 milestone Jun 29, 2024
@shahzadlone shahzadlone merged commit e2b205d into sourcenetwork:develop Jun 29, 2024
38 of 39 checks passed
@shahzadlone shahzadlone deleted the lone/fix/broken-golibp2p branch June 29, 2024 17:54
@shahzadlone
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump Bumped version for something dependencies Related to dependencies deprecate Indicates something is deprecated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants