-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i): Default field value overwrite on update #3030
fix(i): Default field value overwrite on update #3030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3030 +/- ##
===========================================
- Coverage 79.34% 79.32% -0.02%
===========================================
Files 333 333
Lines 25841 25840 -1
===========================================
- Hits 20502 20495 -7
- Misses 3870 3876 +6
Partials 1469 1469
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice find!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Relevant issue(s)
Resolves #3029
Description
This PR fixes an issue where default field values would overwrite any missing input fields.
Tasks
How has this been tested?
Added integration test
Specify the platform(s) on which this was tested: