Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Default field value overwrite on update #3030

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

nasdf
Copy link
Member

@nasdf nasdf commented Sep 18, 2024

Relevant issue(s)

Resolves #3029

Description

This PR fixes an issue where default field values would overwrite any missing input fields.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Added integration test

Specify the platform(s) on which this was tested:

  • MacOS

@nasdf nasdf added bug Something isn't working area/query Related to the query component labels Sep 18, 2024
@nasdf nasdf added this to the DefraDB v0.14 milestone Sep 18, 2024
@nasdf nasdf self-assigned this Sep 18, 2024
@nasdf nasdf requested a review from a team September 18, 2024 16:15
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.32%. Comparing base (5754d7d) to head (59f15d1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3030      +/-   ##
===========================================
- Coverage    79.34%   79.32%   -0.02%     
===========================================
  Files          333      333              
  Lines        25841    25840       -1     
===========================================
- Hits         20502    20495       -7     
- Misses        3870     3876       +6     
  Partials      1469     1469              
Flag Coverage Δ
all-tests 79.32% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/request/graphql/schema/generate.go 87.95% <100.00%> (-0.02%) ⬇️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5754d7d...59f15d1. Read the comment docs.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice find!

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nasdf nasdf merged commit cddc6d6 into sourcenetwork:develop Sep 19, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL updates with default values overwrite
3 participants