Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i): Fix incorrect flag and env variable #3034

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #3033

Description

The flag and environment variable was kept unchanged from an initial commit in the non-interactive keyring PR. This fixes the mistake.

@fredcarle fredcarle added the documentation Improvements or additions to documentation label Sep 18, 2024
@fredcarle fredcarle added this to the DefraDB v0.14 milestone Sep 18, 2024
@fredcarle fredcarle requested a review from a team September 18, 2024 23:33
@fredcarle fredcarle self-assigned this Sep 18, 2024
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.38%. Comparing base (5b58c19) to head (87c0d19).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3034   +/-   ##
========================================
  Coverage    79.38%   79.38%           
========================================
  Files          333      333           
  Lines        25837    25837           
========================================
  Hits         20509    20509           
- Misses        3864     3866    +2     
+ Partials      1464     1462    -2     
Flag Coverage Δ
all-tests 79.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cli/keyring_export.go 81.82% <100.00%> (ø)
cli/keyring_generate.go 78.72% <100.00%> (ø)
cli/keyring_import.go 80.95% <100.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b58c19...87c0d19. Read the comment docs.

@fredcarle fredcarle merged commit 09b49c6 into sourcenetwork:develop Sep 19, 2024
42 of 44 checks passed
@fredcarle fredcarle deleted the fredcarle/docs/fix-incorrect-env-and-flag branch September 19, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environment variable and secret-file flag is wrong in README
2 participants