-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i): SetReplicator and DeleteReplicator params #3175
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3175 +/- ##
===========================================
+ Coverage 77.98% 78.04% +0.05%
===========================================
Files 354 354
Lines 34669 34672 +3
===========================================
+ Hits 27036 27057 +21
+ Misses 6003 5991 -12
+ Partials 1630 1624 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
// Collections is the list of collection names to replicate. | ||
Collections []string | ||
} | ||
|
||
// Replicator is a peer that a set of local collections are replicated to. | ||
type Replicator struct { | ||
Info peer.AddrInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: Might as well change the Schema
to Collection
to match ReplicatorParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Schemas
field contains schema roots though not collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Disregard my thought then. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one thougth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relevant issue(s)
Resolves #3159
Description
This PR fixes an issue where replicator params that are not modifiable were exposed to the client API.
Tasks
How has this been tested?
Existing integration tests.
Specify the platform(s) on which this was tested: