Fix library/helpers.rb pulling different package names with multiple PG installations

[Justin-Fernbaugh]

Description

Describe what this change achieves

Currently with multiple PG installations "installed_postgresql_major_version" and "installed_postgresql_package_source" have a chance to pull a different package from each other. The fix is to sort the packages after being filtered such that calling ".first" always returns the same value.

Issues Resolved

The functions "installed_postgresql_major_version" and "installed_postgresql_package_source" will maintain the same value.

Check List

• A summary of changes made is included in the CHANGELOG under ## Unreleased
• New functionality includes testing.
• New functionality has been documented in the README if applicable.

[ramereth]

This doesn't seem to work properly and I'm confused why you're converting that value to an int. If I just change it to the following, it seems to work properly.

Suggested change

	pgsql_package = pgsql_package.sort_by { |key, _values| key[1].to_i }.to_h
	pgsql_package = pgsql_package.sort_by { |key, _values| key }.to_h

[bmhughes]

I agree with @ramereth here, it doesn't work nor make sense from what I can work out. I'd sort against the version key if we wanted to always order by version but that doesn't necessarily help us out.

I'm thinking the better option would be to move the package match logic into a seperate method which installed_postgresql_major_version and installed_postgresql_package_source could use to get the package so they'll always tie up.

Further to that, I think that matching more than one package is an unknown that we can't handle 100% so it might be better to raise if we get more than one package matched.

[Justin-Fernbaugh]

Really appreciate the suggestions on how to improve this. @bmhughes Moving the matching logic into a function I agree makes a lot of sense here. With that said, the goal of sorting was to select for the newest PG version in order to somewhat accommodate multiple PG installations.

What are the thoughts on implementing a property overriding the match found from either installed_postgresql_major_version or installed_postgresql_package_source . This way those who have more than one PG version on a machine can force one to be used. Also, I'm suggesting to implement this so that upgrades can be performed without having to write custom resource. Thanks for the feedback

[ramereth]

@bmhughes As @Justin-Fernbaugh mentioned, this logic is only needed during an in-place upgrade when you will have multiple versions installed. This provides a stable fix so that we can safely do this. This isn't intended to be used long term on a node.

[ramereth]

@Justin-Fernbaugh can you please update and rebase?

[Justin-Fernbaugh]

@Justin-Fernbaugh can you please update and rebase?

Just pulled and rebased

[ramereth]

@bmhughes let me know if you have any other concerns and what kind of a bump you'd like

[bmhughes]

Sorry I've completely missed this pinging away, let me re-review and try some things out.

Re-review

[bmhughes]

I'm going to merge this but on the whole I'm not 100% sure this is the correct way to go, I thinking it'd be better to raise on multiple versions detected and force the user to explicitly specify the version they want to work on rather than have an implicit behaviour that isn't necessarily deterministic.

But let's see how it goes.

[kitchen-porter]

Released as: 11.10.0