Merge pull request #286 from yanbowe/main

perf(components): Optimize internationalized menu search code
soybeanjs · Oct 18, 2023 · ecbb96f · ecbb96f · vercel · Oct 18, 2023
2 parents 04d3330 + 296a2d2
commit ecbb96f
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/src/layouts/common/global-search/components/search-modal.vue b/src/layouts/common/global-search/components/search-modal.vue
@@ -84,20 +84,11 @@ watch(show, async val => {
 /** 查询 */
 function search() {
   resultOptions.value = routeStore.searchMenus.filter(menu => {
-    return (
-      (keyword.value &&
-        menu.meta?.i18nTitle &&
-        $t(menu.meta?.i18nTitle)
-          .toLocaleLowerCase()
-          .includes(keyword.value.toLocaleLowerCase().trim())) ||
-      menu.meta?.title.toLocaleLowerCase().includes(keyword.value.toLocaleLowerCase().trim())
-    );
+    const trimKeyword = keyword.value.toLocaleLowerCase().trim();
+    const title = (menu.meta.i18nTitle ? $t(menu.meta.i18nTitle) : menu.meta.title).toLocaleLowerCase();
+    return trimKeyword && title.includes(trimKeyword);
   });
-  if (resultOptions.value?.length > 0) {
-    activePath.value = resultOptions.value[0].path;
-  } else {
-    activePath.value = '';
-  }
+  activePath.value = resultOptions.value[0]?.path ?? '';
 }
 
 function handleClose() {