-
Notifications
You must be signed in to change notification settings - Fork 175
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
19 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,30 @@ | ||
# Expand pneumatic valves to have a GUI and inversible | ||
# Short, Properly Capitalized Title | ||
|
||
Your title should convey the basic jist of your proposed changes. It should be short because the text will be linked in the sidebar. | ||
|
||
| Designers | Implemented | GitHub Links | | ||
|---|---|---| | ||
| Sinbiosis | :x: No | TBD | | ||
| Your Names Here | :white_check_mark: Yes or :warning: Partially or :information_source: Open PR or :x: No | PR Links or TBD | | ||
|
||
`Designers` should be the names that you use on GitHub and/or Discord. This is optional but strongly recommended, since: | ||
|
||
- This acknowledges credit where it is due | ||
- People who are confused about the written intent can use this information to contact the authors | ||
|
||
`Implemented` is the status of the feature. | ||
|
||
Github links can include multiple PRs, if relevant. | ||
|
||
## Overview | ||
|
||
Pneumatic valves currently have no GUI to configure things like threshold or gain. Pneumatic valves also can't be inversed (explained below). This PR seeks to implement both features and to make inversibility a toggle within the GUI. | ||
A very short, maybe three sentence summary of what this proposal is about. A high level "overview" or "what this adds". | ||
|
||
## Background | ||
|
||
Pneumatic valves are like transistors, but for pressure-based systems. The current implementation of these valves is limited and only acts like an NMOS transistor. The "inverse" of this is the PMOS transistor, which for the pneumatic valve, hence forth called the "inverse pneumatic valve", means it allows flow between input and output, but only when the control is 1 atm BELOW whichever port is the higher of the two. I.e. If output > input AND control - 1 atm < output then allow flow. If output < input AND control - 1 atm < input then allow flow. | ||
Summarize any information that is needed to contextualize the proposed changes, e.g. the current state of the game. | ||
|
||
Also link any relevant discussions on Discord, GitHub, or HackMD that are relevant to the proposal. | ||
|
||
## Motivation | ||
## The rest? | ||
|
||
Having a GUI for the pneumatic valve can improve the intuitive usability of the valve. Additionally, being able to toggle the inversbility of the pneumatic valve can lead to a lot of FUN™. | ||
Is entirely up to you. |