feat(Next.JS): Support server-side Next.JS usage #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on this is now not working... it was before. Investigating. |
|
@alessandrokonrad this change works when I build it off of 0.9.8 (as you recommended in the original ticket), but not off of 0.10.7. Any reason why that would be? How do you want to address this, publishing an npm patch called 0.9.8-nextjs? |
Next.JS disallows relative imports since 12.0.1 (see https://nextjs.org/docs/messages/middleware-relative-urls for more information). So, we need to sniff out if we are in the NEXTJS environment and if so, use the fallback URL. This should resolve: spacebudz#174 [ Testing: deno task build ]
thaddeusdiamond
force-pushed
the
main
branch
from
0a61e5b to
a125e98
Compare
|
@thaddeusdiamond Followup on this PR, tested this PR in a test/production app and works as indended. Would strongly recommend this gets merged, otherwise other next users will fall into the rabbit hole of why certain .wasm functions break and its tricky to debug without going into the module code. Next is now more heavily server-side than before so I expect more users to run into this issue. |
Merge Latest Conway Changes
Ideally we would want to use the paradigm that the build process set out to pull from a local lib, but we can't for NextJS. Since this is a fork, we don't need to worry about a circular dependency (the fork will pull from the main). Without this, NextJS splits the libraries into chunks and the path resolution fails. [ Testing: npm i lucid-cardano-nextjs@0.10.10-b4 ]
thaddeusdiamond
force-pushed
the
main
branch
from
712aeeb to
e13f382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.JS disallows relative imports since 12.0.1 (see https://nextjs.org/docs/messages/middleware-relative-urls for more information). So, we need to sniff out if we are in the NEXTJS environment and if so, use the fallback URL.
This should resolve:
#174
[ Testing: deno task build ]