Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "testing" feature to "for-internal-testing-only" #1453

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

joshtriplett
Copy link
Contributor

Rather than having a feature named "testing" that external users might
be tempted to incorrectly use (and a detailed comment discouraging them,
which people may or may not see), rename the feature to
"for-internal-testing-only" so that nobody gets any wrong ideas about
whether it's meant for them.

Rather than having a feature named "testing" that external users might
be tempted to incorrectly use (and a detailed comment discouraging them,
which people may or may not see), rename the feature to
"for-internal-testing-only" so that nobody gets any wrong ideas about
whether it's meant for them.
@joshtriplett
Copy link
Contributor Author

Sorry, I sent this for the main branch before realizing that sled 1.0 development is on a different branch. Doesn't look like this is needed on the latter. If you're not looking for changes on the main branch, feel free to close this.

@spacejam
Copy link
Owner

spacejam commented Aug 5, 2023

Thanks, Josh :) While the 1.0 branch doesn't have this yet, it will receive some amount of test-only event tracking / expensive assertion verifiers that will use a feature, and I like using the feature name you proposed, so I'll merge it into main and port it to 1.0 when adding the new verification layers.

@spacejam spacejam merged commit 005c023 into spacejam:main Aug 5, 2023
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants