Skip to content

Commit

Permalink
test(activation): remove parallelism on poet test (#6228)
Browse files Browse the repository at this point in the history
## Motivation

Removing `t.Parallel` to improve test flakes.
  • Loading branch information
acud committed Aug 7, 2024
1 parent a79bdbb commit 65d6614
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions activation/poet_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import (
)

func Test_HTTPPoetClient_ParsesURL(t *testing.T) {
t.Parallel()
cfg := server.DefaultRoundConfig()

t.Run("add http if missing", func(t *testing.T) {
Expand All @@ -52,7 +51,6 @@ func Test_HTTPPoetClient_ParsesURL(t *testing.T) {
}

func Test_HTTPPoetClient_Submit(t *testing.T) {
t.Parallel()
mux := http.NewServeMux()
mux.HandleFunc("POST /v1/submit", func(w http.ResponseWriter, r *http.Request) {
resp, err := protojson.Marshal(&rpcapi.SubmitResponse{})
Expand Down Expand Up @@ -85,7 +83,6 @@ func Test_HTTPPoetClient_Submit(t *testing.T) {
}

func Test_HTTPPoetClient_Address(t *testing.T) {
t.Parallel()
t.Run("with scheme", func(t *testing.T) {
t.Parallel()
client, err := NewHTTPPoetClient(types.PoetServer{Address: "https://poet-address"}, PoetConfig{})
Expand All @@ -103,7 +100,6 @@ func Test_HTTPPoetClient_Address(t *testing.T) {
}

func Test_HTTPPoetClient_Address_Mainnet(t *testing.T) {
t.Parallel()
poetCfg := server.DefaultRoundConfig()

poETServers := []string{
Expand All @@ -126,7 +122,6 @@ func Test_HTTPPoetClient_Address_Mainnet(t *testing.T) {
}

func Test_HTTPPoetClient_Proof(t *testing.T) {
t.Parallel()
mux := http.NewServeMux()
mux.HandleFunc("GET /v1/proofs/1", func(w http.ResponseWriter, r *http.Request) {
resp, err := protojson.Marshal(&rpcapi.ProofResponse{})
Expand All @@ -151,8 +146,6 @@ func Test_HTTPPoetClient_Proof(t *testing.T) {
}

func TestPoetClient_CachesProof(t *testing.T) {
t.Parallel()

var proofsCalled atomic.Uint64
mux := http.NewServeMux()
mux.HandleFunc("GET /v1/proofs/", func(w http.ResponseWriter, r *http.Request) {
Expand Down Expand Up @@ -197,8 +190,6 @@ func TestPoetClient_CachesProof(t *testing.T) {
}

func TestPoetClient_QueryProofTimeout(t *testing.T) {
t.Parallel()

block := make(chan struct{})
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
<-block
Expand Down Expand Up @@ -231,8 +222,6 @@ func TestPoetClient_QueryProofTimeout(t *testing.T) {
}

func TestPoetClient_Certify(t *testing.T) {
t.Parallel()

sig, err := signing.NewEdSigner()
require.NoError(t, err)

Expand Down Expand Up @@ -273,8 +262,6 @@ func TestPoetClient_Certify(t *testing.T) {
}

func TestPoetClient_ObtainsCertOnSubmit(t *testing.T) {
t.Parallel()

sig, err := signing.NewEdSigner()
require.NoError(t, err)

Expand Down Expand Up @@ -318,8 +305,6 @@ func TestPoetClient_ObtainsCertOnSubmit(t *testing.T) {
}

func TestPoetClient_RecertifiesOnAuthFailure(t *testing.T) {
t.Parallel()

sig, err := signing.NewEdSigner()
require.NoError(t, err)

Expand Down Expand Up @@ -386,8 +371,6 @@ func TestPoetClient_RecertifiesOnAuthFailure(t *testing.T) {
}

func TestPoetClient_FallbacksToPowWhenCannotRecertify(t *testing.T) {
t.Parallel()

sig, err := signing.NewEdSigner()
require.NoError(t, err)

Expand Down Expand Up @@ -460,7 +443,6 @@ func TestPoetClient_FallbacksToPowWhenCannotRecertify(t *testing.T) {
}

func TestPoetService_CachesCertifierInfo(t *testing.T) {
t.Parallel()
type test struct {
name string
ttl time.Duration
Expand Down Expand Up @@ -493,7 +475,6 @@ func TestPoetService_CachesCertifierInfo(t *testing.T) {
}

func TestPoetService_CachesPowParams(t *testing.T) {
t.Parallel()
type test struct {
name string
ttl time.Duration
Expand Down

0 comments on commit 65d6614

Please sign in to comment.