Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update dependencies not checked by dependabot #4979

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update dependencies not checked by dependabot #4979

wants to merge 1 commit into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Sep 7, 2023 •
edited
Loading

Motivation

Updates dependencies not covered by dependabot (libraries without tagged versions)

Changes

  • Update github.com/chaos-mesh/chaos-mesh/api
  • Update github.com/oasisprotocol/curve25519-voi

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat requested a review from countvonzero as a code owner September 7, 2023 17:38
@fasmat fasmat self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #4979 (fe475dd) into develop (2cb15f9) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #4979     +/-   ##
=========================================
- Coverage     77.1%   77.1%   -0.1%     
=========================================
  Files          254     254             
  Lines        30253   30253             
=========================================
- Hits         23345   23342      -3     
- Misses        5394    5396      +2     
- Partials      1514    1515      +1

see 4 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@dshulyak
Copy link
Contributor

dshulyak commented Sep 7, 2023 •
edited
Loading

github.com/oasisprotocol/curve25519-voi

we should check if there was no changes. in the past ecvrf that we use was updated because rfc changed. maybe compile and run on mainnet?

@fasmat
Copy link
Member Author

fasmat commented Sep 7, 2023 •
edited
Loading

github.com/oasisprotocol/curve25519-voi

we should check if there was no changes. in the past ecvrf that we use was updated because rfc changed. maybe compile and run on mainnet?

Fair point. I checked the diff; it is only two commits: oasisprotocol/curve25519-voi@db37f07...1f23a7b

No existing code was changed, just new functionality added 🙂

@fasmat fasmat force-pushed the update-unversioned-dependencies branch from 5021c55 to 720dfb2 Compare September 8, 2023 10:03
@fasmat
Copy link
Member Author

fasmat commented Sep 8, 2023

bors merge

@bors
Copy link

bors bot commented Sep 8, 2023

Merge conflict.

@fasmat fasmat force-pushed the update-unversioned-dependencies branch from 720dfb2 to fe475dd Compare September 8, 2023 12:26
@fasmat
Copy link
Member Author

fasmat commented Sep 8, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2023
@fasmat
Update dependencies not checked by dependabot (#4979)
3092724 
## Motivation
Updates dependencies not covered by dependabot (libraries without tagged versions)

## Changes
- Update `github.com/chaos-mesh/chaos-mesh/api`
- Update `github.com/oasisprotocol/curve25519-voi`

## Test Plan
existing tests pass

## TODO
<!-- This section should be removed when all items are complete -->
- [x] Explain motivation or link existing issue(s)
- [x] Test changes and document test plan
- [x] Update documentation as needed
- [ ] Update [changelog](../CHANGELOG.md) as needed
@bors
Copy link

bors bot commented Sep 8, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Update dependencies not checked by dependabot [Merged by Bors] - Update dependencies not checked by dependabot Sep 8, 2023
@bors bors bot closed this Sep 8, 2023
@bors bors bot deleted the update-unversioned-dependencies branch September 8, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poszu poszu poszu approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

Assignees

@fasmat fasmat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fasmat @dshulyak @poszu