[Merged by Bors] - Add new PoET config "poet-request-timeout" and use it instead of GracePeriod for timeouts #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
rename-grace-period
branch
3 times, most recently
from
44eb577 to
cdf8cf9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4996 +/- ##
=======================================
Coverage 77.1% 77.1%
=======================================
Files 254 254
Lines 30296 30301 +5
=======================================
+ Hits 23363 23377 +14
+ Misses 5416 5404 -12
- Partials 1517 1520 +3
|
|
bors try |
|
bors try |
tryAlready running a review |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
fasmat
force-pushed
the
rename-grace-period
branch
from
05e5f75 to
4eed88f
Compare
poszu
reviewed
Sep 12, 2023
fasmat
force-pushed
the
rename-grace-period
branch
from
e2736c8 to
cab09ff
Compare
poszu
approved these changes
Sep 12, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ePeriod for timeouts (#4996) ## Motivation The NiPoST builder uses `GracePeriod` for two different (unrelated) things: one is a duration relative to a PoET round start. A node waits until then before it starts creating and submitting a challenge to PoET (so that it uses the highest possible ATX it sees until then). The other use is as a request timeout for requests to PoET. For this a new config parameter "poet-request-timeout" is added to the config. This allows to set much shorter timeouts (1 hour on mainnet is much too long). ## Changes - add new config parameter "poet-request-timeout" - the defaults are calculated from the maximum time a request can take based on the linear jitter backoff ## Test Plan existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ePeriod for timeouts (#4996) ## Motivation The NiPoST builder uses `GracePeriod` for two different (unrelated) things: one is a duration relative to a PoET round start. A node waits until then before it starts creating and submitting a challenge to PoET (so that it uses the highest possible ATX it sees until then). The other use is as a request timeout for requests to PoET. For this a new config parameter "poet-request-timeout" is added to the config. This allows to set much shorter timeouts (1 hour on mainnet is much too long). ## Changes - add new config parameter "poet-request-timeout" - the defaults are calculated from the maximum time a request can take based on the linear jitter backoff ## Test Plan existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
…ePeriod for timeouts (#4996) ## Motivation The NiPoST builder uses `GracePeriod` for two different (unrelated) things: one is a duration relative to a PoET round start. A node waits until then before it starts creating and submitting a challenge to PoET (so that it uses the highest possible ATX it sees until then). The other use is as a request timeout for requests to PoET. For this a new config parameter "poet-request-timeout" is added to the config. This allows to set much shorter timeouts (1 hour on mainnet is much too long). ## Changes - add new config parameter "poet-request-timeout" - the defaults are calculated from the maximum time a request can take based on the linear jitter backoff ## Test Plan existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NiPoST builder uses
GracePeriodfor two different (unrelated) things: one is a duration relative to a PoET round start. A node waits until then before it starts creating and submitting a challenge to PoET (so that it uses the highest possible ATX it sees until then).The other use is as a request timeout for requests to PoET. For this a new config parameter "poet-request-timeout" is added to the config. This allows to set much shorter timeouts (1 hour on mainnet is much too long).
Changes
Test Plan
existing tests pass
TODO