[Merged by Bors] - use first applied block in epoch for new miner active set #4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
requested review from
dshulyak,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #4997 +/- ##
=======================================
Coverage 77.1% 77.1%
=======================================
Files 254 254
Lines 30355 30385 +30
=======================================
+ Hits 23430 23457 +27
- Misses 5404 5405 +1
- Partials 1521 1523 +2
|
countvonzero
force-pushed
the
relax-first-in-epoch
branch
from
8b84a98 to
3631e6a
Compare
countvonzero
changed the title
dshulyak
approved these changes
Sep 12, 2023
miner/util.go
Outdated
| } | ||
|
|
||
| func ActiveSetFromEpochFirstBlock(db sql.Executor, epoch types.EpochID) ([]types.ATXID, error) { | ||
| result, err := ActiveSetFromEpochFirstCertifiedBlock(db, epoch) |
There was a problem hiding this comment.
this would be a different block for synced node, i think it should be always first applied regardless of certificate
|
i think it is this bug #4912 |
not aware of this. thanks! |
countvonzero
changed the title
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
## Motivation Closes #4912 ## Changes - for new miner use the first applied block for ref ballot active set
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
## Motivation Closes #4912 ## Changes - for new miner use the first applied block for ref ballot active set
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
## Motivation follow up on #4997 doing the same for hare active set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4912
Changes