[Merged by Bors] - tortoise: reuse decoded votes #5009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
requested review from
countvonzero,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5009 +/- ##
=======================================
Coverage 77.0% 77.1%
=======================================
Files 257 257
Lines 30236 30254 +18
=======================================
+ Hits 23311 23335 +24
+ Misses 5399 5394 -5
+ Partials 1526 1525 -1
|
countvonzero
approved these changes
Sep 14, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
related: #3006 it also reduced 300MB of used memory on my machine. ballot signs opinion hash, and provides sidecar to decode that opinion hash. if node decoded one sidecar it can store it in memory and reuse for all following ballots with the same opinion hash.
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #3006
it also reduced 300MB of used memory on my machine.
ballot signs opinion hash, and provides sidecar to decode that opinion hash. if node decoded one sidecar it can store it in memory
and reuse for all following ballots with the same opinion hash.