[Merged by Bors] - Replace clock mocking library #5017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
countvonzero,
dshulyak and
poszu
as code owners
|
bors try |
Codecov Report
@@ Coverage Diff @@
## develop #5017 +/- ##
=========================================
- Coverage 77.2% 77.1% -0.1%
=========================================
Files 254 254
Lines 30350 30350
=========================================
- Hits 23433 23423 -10
- Misses 5397 5408 +11
+ Partials 1520 1519 -1
|
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
dshulyak
approved these changes
Sep 15, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
## Motivation `github.com/benbjohnson/clock` has been archived a while ago. This PR replaces the outdated dependency with `github.com/jonboulle/clockwork`. ## Changes - Replace uses of `github.com/benbjohnson/clock` with `github.com/jonboulle/clockwork` ## Test Plan existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Build failed: |
|
Flaky test bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
## Motivation `github.com/benbjohnson/clock` has been archived a while ago. This PR replaces the outdated dependency with `github.com/jonboulle/clockwork`. ## Changes - Replace uses of `github.com/benbjohnson/clock` with `github.com/jonboulle/clockwork` ## Test Plan existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
github.com/benbjohnson/clockhas been archived a while ago. This PR replaces the outdated dependency withgithub.com/jonboulle/clockwork.Changes
github.com/benbjohnson/clockwithgithub.com/jonboulle/clockworkTest Plan
existing tests pass
TODO