Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Bump poet to v0.9.5 #5043

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Bump poet to v0.9.5 #5043

wants to merge 4 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Sep 20, 2023

Changes

Bumped poet to the latest available version

Test Plan

Existing tests should pass

@poszu
Copy link
Contributor Author

poszu commented Sep 20, 2023

bors try

bors bot added a commit that referenced this pull request Sep 20, 2023
@bors
Try #5043:
4e4ad84
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #5043 (f016a6a) into develop (8454236) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #5043   +/-   ##
=======================================
  Coverage     77.0%   77.1%           
=======================================
  Files          257     257           
  Lines        30280   30275    -5     
=======================================
+ Hits         23345   23346    +1     
+ Misses        5406    5402    -4     
+ Partials      1529    1527    -2
Files Changed Coverage Δ
activation/poet_test_harness.go 92.3% <100.0%> (+6.9%) ⬆️
node/node.go 63.6% <100.0%> (+0.1%) ⬆️

... and 2 files with indirect coverage changes

@poszu poszu changed the title Bump poet to v0.9.5-rc2 Bump poet to v0.9.5 Sep 20, 2023
@bors
Copy link

bors bot commented Sep 20, 2023

try

Build failed:

@poszu poszu marked this pull request as ready for review September 20, 2023 18:46
@poszu
Copy link
Contributor Author

poszu commented Sep 20, 2023

bors try

bors bot added a commit that referenced this pull request Sep 20, 2023
@bors
Try #5043:
b1e9c56
fasmat
fasmat approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is kinda large because it also updates go.uber.org/mock. I hope dependabot soon creates new PRs for those after we hopefully fixed it to avoid having to mix in these updates with other changes 😕

@bors
Copy link

bors bot commented Sep 20, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@poszu
Copy link
Contributor Author

poszu commented Sep 20, 2023

Bors merge

@bors
Copy link

bors bot commented Sep 20, 2023

Merge conflict.

@poszu
Copy link
Contributor Author

poszu commented Sep 21, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 21, 2023
@poszu
Bump poet to v0.9.5 (#5043)
c7d42cf 
## Changes
Bumped poet to the latest available version

## Test Plan
Existing tests should pass
@bors
Copy link

bors bot commented Sep 21, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Bump poet to v0.9.5 [Merged by Bors] - Bump poet to v0.9.5 Sep 21, 2023
@bors bors bot closed this Sep 21, 2023
@bors bors bot deleted the bump-poet-v0.9.5 branch September 21, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

@countvonzero countvonzero Awaiting requested review from countvonzero

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poszu @fasmat