Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - proposals: dont accept proposals from future #5065

Closed
wants to merge 2 commits into from

Conversation

dshulyak
Copy link
Contributor

closes: #4834

no reason to gate ballots, as we request them with sync, so they won't be downloaded

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5065 (acf1a1d) into develop (c51f2a1) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #5065   +/-   ##
=======================================
  Coverage     77.1%   77.1%           
=======================================
  Files          257     257           
  Lines        30277   30278    +1     
=======================================
+ Hits         23348   23353    +5     
+ Misses        5403    5399    -4     
  Partials      1526    1526           
Files Changed Coverage Δ
proposals/handler.go 87.5% <100.0%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 22, 2023
closes: #4834

no reason to gate ballots, as we request them with sync, so they won't be downloaded
@bors
Copy link

bors bot commented Sep 22, 2023

Build failed:

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 22, 2023
closes: #4834

no reason to gate ballots, as we request them with sync, so they won't be downloaded
@bors
Copy link

bors bot commented Sep 22, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title proposals: dont accept proposals from future [Merged by Bors] - proposals: dont accept proposals from future Sep 22, 2023
@bors bors bot closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ballots, proposal: don't accept object from future
2 participants