Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - sql: dont read dbstat by default #5067

Conversation

dshulyak
Copy link
Contributor

this is debug information and can be enabled to be collected.
moreover reading dbstat frequently can interfere with other workloads.

allow to disable it by setting interval to 0
@dshulyak dshulyak requested a review from pigmej September 22, 2023 17:06
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #5067 (a6c7f4f) into develop (ca91fc5) will increase coverage by 0.0%.
The diff coverage is 91.6%.

❗ Current head a6c7f4f differs from pull request most recent head 686b5d8. Consider uploading reports for the commit 686b5d8 to get more accurate results

@@           Coverage Diff           @@
##           develop   #5067   +/-   ##
=======================================
  Coverage     77.0%   77.1%           
=======================================
  Files          257     257           
  Lines        30275   30277    +2     
=======================================
+ Hits         23331   23354   +23     
+ Misses        5420    5398   -22     
- Partials      1524    1525    +1     
Files Changed Coverage Δ
node/node.go 63.6% <0.0%> (ø)
config/config.go 100.0% <100.0%> (ø)
config/presets/testnet.go 95.6% <100.0%> (+<0.1%) ⬆️

... and 4 files with indirect coverage changes

@dshulyak
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 25, 2023
this is debug information and can be enabled to be collected.
moreover reading dbstat frequently can interfere with other workloads.
@bors
Copy link

bors bot commented Sep 25, 2023

Pull request successfully merged into develop.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title sql: dont read dbstat by default [Merged by Bors] - sql: dont read dbstat by default Sep 25, 2023
@bors bors bot closed this Sep 25, 2023
dshulyak added a commit that referenced this pull request Sep 25, 2023
this is debug information and can be enabled to be collected.
moreover reading dbstat frequently can interfere with other workloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants