Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - ATX v2 (for ATX merge) #5785
[Merged by Bors] - ATX v2 (for ATX merge) #5785
Changes from 9 commits
e43abc3
be18640
93e4d58
ec2b89b
604774d
7a72409
11d5bab
6cdb6cd
ef17cdb
c242e1f
e387a88
851ee6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 28 in activation/wire/challenge_v2.go
Codecov / codecov/patch
activation/wire/challenge_v2.go#L26-L28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably also be changed to be the root of a merkle tree formed by the
NiPostChallengeV2
, to ensure we can proof any field to be a specific value in a malfeasance proof without having to attach the full ATX. We just need to make sure that theNiPostChallengeV2
is attached via its root to the tree to be able to extract each field individually.Regarding pre-image resistance: we need to check if this is still needed with the new signature scheme.
Check warning on line 33 in activation/wire/challenge_v2.go
Codecov / codecov/patch
activation/wire/challenge_v2.go#L31-L33
Check warning on line 39 in activation/wire/challenge_v2.go
Codecov / codecov/patch
activation/wire/challenge_v2.go#L35-L39
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.