Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - api: v2alpha1 transaction service #5933

Closed
wants to merge 14 commits into from

Apply review suggestions

cbc5aa7
Select commit
Loading
Failed to load commit list.
Closed

[Merged by Bors] - api: v2alpha1 transaction service #5933

Apply review suggestions
cbc5aa7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 23, 2024 in 0s

80.7% (-0.1%) compared to 166e015

View this Pull Request on Codecov

80.7% (-0.1%) compared to 166e015

Details

Codecov Report

Attention: Patch coverage is 77.15134% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 80.7%. Comparing base (166e015) to head (cbc5aa7).
Report is 4 commits behind head on develop.

Files Patch % Lines
api/grpcserver/v2alpha1/transaction.go 73.2% 52 Missing and 18 partials ⚠️
sql/transactions/transactions.go 77.2% 3 Missing and 2 partials ⚠️
sql/builder/builder.go 93.1% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #5933     +/-   ##
=========================================
- Coverage     80.8%   80.7%   -0.1%     
=========================================
  Files          287     288      +1     
  Lines        29905   30232    +327     
=========================================
+ Hits         24182   24424    +242     
- Misses        4140    4202     +62     
- Partials      1583    1606     +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov