[Merged by Bors] - Pin version of runner images #5962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmello
approved these changes
May 21, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 21, 2024
## Motivation `ubuntu-latest` and `windows-latest` might change which VM we get over time. For ubuntu it is expected that in August 2024 `ubuntu-latest` will not resolve to `ubuntu-22.04` any more but to `ubuntu-24.04`. To avoid surprises we should select the oldest version we want to support and upgrade when we want to.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5962 +/- ##
=======================================
Coverage 80.8% 80.8%
=======================================
Files 287 287
Lines 29696 29696
=======================================
+ Hits 24007 24008 +1
Misses 4121 4121
+ Partials 1568 1567 -1 ☔ View full report in Codecov by Sentry. |
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 21, 2024
## Motivation `ubuntu-latest` and `windows-latest` might change which VM we get over time. For ubuntu it is expected that in August 2024 `ubuntu-latest` will not resolve to `ubuntu-22.04` any more but to `ubuntu-24.04`. To avoid surprises we should select the oldest version we want to support and upgrade when we want to.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ubuntu-latestandwindows-latestmight change which VM we get over time. For ubuntu it is expected that in August 2024ubuntu-latestwill not resolve toubuntu-22.04any more but toubuntu-24.04. To avoid surprises we should select the oldest version we want to support and upgrade when we want to.Description
Replaced all instances of
ubuntu-latestwithubuntu-22.04andwindows-latestwithwindows-2019.Test Plan
existing tests pass
TODO