[Merged by Bors] - Simplify switch to different poet services

[ConvallariaMaj]

Motivation

Fix of issue #5563

Description

Implemented:

• check registrations by node id + poet addresses
• if round didn't start and new PoETs added, submit missing registrations. Otherwise work with existing.
• new tests

Test Plan

Tested by unit tests

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[codecov]

Codecov Report

Attention: Patch coverage is 82.32323% with 35 lines in your changes missing coverage. Please review.

Project coverage is 82.1%. Comparing base (83b0499) to head (f9af85a).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
activation/activation_errors.go	6.6%	14 Missing ⚠️
activation/nipost.go	87.6%	10 Missing and 3 partials ⚠️
activation/poet.go	92.5%	3 Missing and 2 partials ⚠️
activation/e2e/poet_client.go	77.7%	2 Missing ⚠️
node/node.go	0.0%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #6116   +/-   ##
=======================================
  Coverage     82.0%   82.1%           
=======================================
  Files          309     309           
  Lines        34033   34120   +87     
=======================================
+ Hits         27919   28014   +95     
+ Misses        4329    4324    -5     
+ Partials      1785    1782    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[poszu]

I think the logic below needs to be updated. The idea was that if all registrations failed and it's already too late to submit, then the challenge expires. I think we could simplify the check now. If we have 0 registrations at the end of this function and the registration deadline passed, we expire the challenge.

	allInvalid := true
	for err := range errChan {
		if err == nil {
			allInvalid = false
			continue
		}
		nb.logger.Warn("failed to submit challenge to poet", zap.Error(err), log.ZShortStringer("smesherID", nodeID))
		if !errors.Is(err, ErrInvalidRequest) {
			allInvalid = false
		}
	}
	if allInvalid {
		nb.logger.Warn("all poet submits were too late. ATX challenge expires", log.ZShortStringer("smesherID", nodeID))

[fasmat]

For me there are now only 2 points left open to merge this PR (see my last 2 comments). @poszu could you also take another look?

[ConvallariaMaj]

bors merge

[spacemesh-bors]

Build failed:

• ci-status

[ConvallariaMaj]

bors merge

[spacemesh-bors]

Pull request successfully merged into develop.

Build succeeded:

• ci-status
• systest-status