[Merged by Bors] - systest: fix RBAC rules for chaos-mesh #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6131 +/- ##
=======================================
Coverage 81.7% 81.8%
=======================================
Files 302 302
Lines 32637 32637
=======================================
+ Hits 26695 26709 +14
+ Misses 4204 4192 -12
+ Partials 1738 1736 -2 ☔ View full report in Codecov by Sentry. |
|
It seems the systests should fail consistently if they miss permissions. Could you explain what is going on there? |
because I assume we don't have RBAC enabled? |
|
bors merge |
|
👎 Rejected by too few approved reviews |
|
oops missed that it's not approved yet, PTAL folks |
poszu
approved these changes
Jul 12, 2024
fasmat
approved these changes
Jul 15, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
## Motivation Systests are failing when running with RBAC enabled due to chaos-mesh object permissions
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Systests are failing when running with RBAC enabled due to chaos-mesh object permissions
Description
Add RBAC rules for chaos-mesh
Test Plan
Run systests on a custom k3s cluster