[Merged by Bors] - test(systest): add fail-fast for systests #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd make it an option which we may set to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6163 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 302 301 -1
Lines 32630 32630
=======================================
+ Hits 26722 26731 +9
+ Misses 4174 4168 -6
+ Partials 1734 1731 -3 ☔ View full report in Codecov by Sentry. |
|
We do use failfast on unit tests as well, so I don't see why we shouldn't do it also for systests. |
fasmat
approved these changes
Jul 21, 2024
|
bors try |
tryBuild succeeded: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Motivation systests appear to continue execution of all tests regardless if one of them failed.
|
Build failed (retrying...):
|
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Motivation systests appear to continue execution of all tests regardless if one of them failed.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Motivation systests appear to continue execution of all tests regardless if one of them failed.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
## Motivation systests appear to continue execution of all tests regardless if one of them failed.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation systests appear to continue execution of all tests regardless if one of them failed.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
systests appear to continue execution of all tests regardless if one of them failed.
Description
This change might be debatable, because we might want to keep the configuration as is and avoid the fail-fast. One might argue that it doesn't matter if one test failed or all of them and it is better to just know earlier that the flow failed rather than having to wait for a full hour to get the signal.
If the systests weren't flaky I'd say it might be better to know which of the tests failed (maybe multiple, maybe just one out of all). But I'm not sure that right now this is actually of any use and maybe having a faster workflow is better for everyone.
Example can be seen here: https://github.com/spacemeshos/go-spacemesh/actions/runs/10014040215/job/27682907862 (look for
fail:in the logs).Opening to discussion and happy to close this if there's resistance.
Test Plan
TODO