[Merged by Bors] - chore(txs): cleanup logging and error handling #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6170 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 301 301
Lines 32630 32596 -34
=======================================
- Hits 26710 26690 -20
+ Misses 4184 4173 -11
+ Partials 1736 1733 -3 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild failed: |
fasmat
approved these changes
Jul 23, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation Cleans up the `txs` package from excessive logging and antipattern occurrences of `log an error then return it`.
|
Build failed: |
|
git checkout errors on windows bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation Cleans up the `txs` package from excessive logging and antipattern occurrences of `log an error then return it`.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation Cleans up the `txs` package from excessive logging and antipattern occurrences of `log an error then return it`.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Motivation Cleans up the `txs` package from excessive logging and antipattern occurrences of `log an error then return it`.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleans up the
txspackage from excessive logging and antipattern occurrences oflog an error then return it.Description
Test Plan
TODO