[Merged by Bors] - test(systest): improve systest resilience

[acud]

Motivation

Improve systest resilience by retrying some of the checks on the Unavailable error.

Description

Test Plan

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (02bcbe9) to head (afbe21d).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6171     +/-   ##
=========================================
- Coverage     81.9%   81.8%   -0.1%     
=========================================
  Files          301     301             
  Lines        32606   32606             
=========================================
- Hits         26711   26703      -8     
- Misses        4167    4172      +5     
- Partials      1728    1731      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[acud]

bors try

[spacemesh-bors]

try

Build succeeded:

• ci-status
• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build succeeded:

• ci-status
• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build succeeded:

• ci-status
• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build succeeded:

• systest-status
• ci-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build succeeded:

• ci-status
• systest-status

[acud]

bors try

[spacemesh-bors]

try

Build failed:

• systest-status

[poszu]

Wouldn't atomic.Bool be more straightforward to use?

failed atomic.Bool
...
t.Cleanup(func() {
	if t.Failed() {
		failed.Set(true)
	}
})

Suggested change

	func (c *Context) CheckFail() error {
	select {
	case <-failed:
	return errors.New("test suite failed. aborting test execution")
	default:
	}
	return nil
	}
	func (c *Context) CheckFail() error {
	if failed.Load() {
	return errors.New("test suite failed. aborting test execution")
	}
	return nil
	}

[acud]

bors merge

[spacemesh-bors]

Pull request successfully merged into develop.

Build succeeded:

• ci-status
• systest-status