[Merged by Bors] - Remove unused params #6173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unused params
- removed unused params2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6173 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 301 301
Lines 32606 32606
=======================================
+ Hits 26697 26701 +4
+ Misses 4178 4173 -5
- Partials 1731 1732 +1 ☔ View full report in Codecov by Sentry. |
ConvallariaMaj
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
fasmat
reviewed
Jul 23, 2024
fasmat
approved these changes
Jul 23, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed: |
|
bors merge |
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
bors cancel |
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
## Motivation Cleaning up the code a little bit Co-authored-by: ConvallariaMaj <132993066+ConvallariaMaj@users.noreply.github.com>
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleaning up the code a little bit
Description
Removes some unused parameters, fixed some comments
Test Plan
No new tests needed
TODO