Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systest: Update kubernetes client-go dependency and configure rate limiter #6178

Merged

Conversation

dsmello
Copy link
Contributor

@dsmello dsmello commented Jul 25, 2024

The code changes update the kubernetes client-go dependency and configure a rate limiter to prevent the client from being throttled. This improves the performance and prevents the client from being slowed down.

Motivation

To reduce the client throttling during the systest execution, the client limits was increased 4x

Test Plan

run the systest pipeline, and not find any client throttling warning.

  • "due to client-side throttling, not priority and fairness, request"

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update changelog as needed

The code changes update the kubernetes client-go dependency and configure a rate limiter to prevent the client from being throttled. This improves the performance and prevents the client from being slowed down.
@dsmello dsmello self-assigned this Jul 25, 2024
Copy link
Contributor Author

@dsmello dsmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors try

spacemesh-bors bot added a commit that referenced this pull request Jul 25, 2024
@fasmat
Copy link
Member

fasmat commented Jul 25, 2024

@pigmej shall we add this to your PR #6176 to hopefully get both to merge at the same time?

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (f2ecedc) to head (5459a98).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           guaranteed_qos_exp1   #6178     +/-   ##
=====================================================
- Coverage                 81.8%   81.8%   -0.1%     
=====================================================
  Files                      301     301             
  Lines                    32606   32606             
=====================================================
- Hits                     26702   26698      -4     
- Misses                    4173    4177      +4     
  Partials                  1731    1731             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

try

Build failed:

@pigmej pigmej merged commit 3743e0f into guaranteed_qos_exp1 Jul 25, 2024
12 of 19 checks passed
@pigmej pigmej deleted the systest/increase-the-kubecli-request-limits branch July 25, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants