Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Systest :: Increase the request limit on k8s client #6179

Closed
wants to merge 1 commit into from

Conversation

dsmello
Copy link
Contributor

@dsmello dsmello commented Jul 25, 2024

Motivation

Fix the k8s client throttling error and delays during the systest

Description

Change settings to use the same values of kubectl and the argoCD project. The default value is 5qps and 10 burst but the k8s cli uses 50qps and 300burst.

This should prevent the throttle msg during parallel executions.

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

- I changed this to use the same valus of kubectl and the argoCD project
@dsmello dsmello self-assigned this Jul 25, 2024
@fasmat
Copy link
Member

fasmat commented Jul 25, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jul 25, 2024
## Motivation

Fix the k8s client throttling error and delays during the systest
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (02bcbe9) to head (2e933f2).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6179     +/-   ##
=========================================
- Coverage     81.9%   81.8%   -0.1%     
=========================================
  Files          301     301             
  Lines        32606   32606             
=========================================
- Hits         26711   26702      -9     
- Misses        4167    4174      +7     
- Partials      1728    1730      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Systest :: Increase the request limit on k8s client [Merged by Bors] - Systest :: Increase the request limit on k8s client Jul 25, 2024
@spacemesh-bors spacemesh-bors bot closed this Jul 25, 2024
@spacemesh-bors spacemesh-bors bot deleted the systest/increase-the-k8s-client-limit branch July 25, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants