Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: get rid of urfave #6183

Closed
wants to merge 3 commits into from
Closed

Conversation

acud
Copy link
Contributor

@acud acud commented Jul 26, 2024

Motivation

Changing urfave/cli in cmd/merge-nodes in favor of cobra.

Description

Removing this unnecessary dependency. We already depend and use cobra and urfave is just used in one command.

Test Plan

Tests passing.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (02bcbe9) to head (e98838b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6183     +/-   ##
=========================================
- Coverage     81.9%   81.9%   -0.1%     
=========================================
  Files          301     301             
  Lines        32606   32606             
=========================================
- Hits         26711   26706      -5     
- Misses        4167    4172      +5     
  Partials      1728    1728             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acud acud marked this pull request as ready for review July 28, 2024 02:22
@acud
Copy link
Contributor Author

acud commented Jul 28, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Jul 28, 2024
@spacemesh-bors
Copy link

try

Build failed:

cmd/merge-nodes/main.go Outdated Show resolved Hide resolved
@acud
Copy link
Contributor Author

acud commented Jul 29, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jul 29, 2024
## Motivation

Changing `urfave/cli` in `cmd/merge-nodes` in favor of `cobra`.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title chore: get rid of urfave [Merged by Bors] - chore: get rid of urfave Jul 29, 2024
@spacemesh-bors spacemesh-bors bot closed this Jul 29, 2024
@spacemesh-bors spacemesh-bors bot deleted the remove-urfave branch July 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants