[Merged by Bors] - chore(txs): mempool optimization #6185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6185 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 301 301
Lines 32606 32605 -1
=========================================
- Hits 26697 26689 -8
- Misses 4178 4185 +7
Partials 1731 1731 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jul 29, 2024
Comment on lines
558
to
560
| func acceptable(err error) bool { | ||
| return err == nil || errors.Is(err, errInsufficientBalance) || errors.Is(err, errTooManyNonce) | ||
| return err == nil || errors.Is(err, errTooManyNonce) | ||
| } |
There was a problem hiding this comment.
Could you explain in the PR description from a users perspective what this change will accomplish?
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
fasmat
approved these changes
Jul 29, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
## Motivation Improves some aspects of the mempool handling.
|
bors cancel |
|
Canceled. |
ivan4th
approved these changes
Jul 29, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
## Motivation Improves some aspects of the mempool handling.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
## Motivation Improves some aspects of the mempool handling.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
fasmat
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improves some aspects of the mempool handling.
Description
Test Plan
Tests passing
TODO