-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - use zap in timesync #6195
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6195 +/- ##
=========================================
+ Coverage 81.8% 81.9% +0.1%
=========================================
Files 302 300 -2
Lines 32539 32393 -146
=========================================
- Hits 26631 26546 -85
+ Misses 4180 4126 -54
+ Partials 1728 1721 -7 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jul 31, 2024
fasmat
reviewed
Aug 1, 2024
fasmat
approved these changes
Aug 1, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Motivation Part of the effort to migrate to zap.
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
use zap in timesync
[Merged by Bors] - use zap in timesync
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the effort to migrate to zap.
Description
Test Plan
existing tests pass
TODO