Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - use zap in timesync #6195

Closed
wants to merge 4 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jul 31, 2024

Motivation

Part of the effort to migrate to zap.

Description

  • migrated timesync/ to zap
  • removed redundant error structs, which existed to have custom logging, but it was never used

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.9%. Comparing base (f46277b) to head (ebae449).
Report is 1 commits behind head on develop.

Files Patch % Lines
timesync/peersync/sync.go 87.5% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6195     +/-   ##
=========================================
+ Coverage     81.8%   81.9%   +0.1%     
=========================================
  Files          302     300      -2     
  Lines        32539   32393    -146     
=========================================
- Hits         26631   26546     -85     
+ Misses        4180    4126     -54     
+ Partials      1728    1721      -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

timesync/peersync/sync.go Outdated Show resolved Hide resolved
timesync/peersync/sync.go Outdated Show resolved Hide resolved
@poszu poszu requested a review from fasmat August 1, 2024 06:54
timesync/peersync/sync.go Outdated Show resolved Hide resolved
@poszu poszu requested a review from fasmat August 1, 2024 08:21
@poszu
Copy link
Contributor Author

poszu commented Aug 1, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 1, 2024
## Motivation

Part of the effort to migrate to zap.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 1, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title use zap in timesync [Merged by Bors] - use zap in timesync Aug 1, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 1, 2024
@spacemesh-bors spacemesh-bors bot deleted the refactor/use-zap-in-timesync branch August 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants