[Merged by Bors] - cache poet's /v1/pow_params with TTL #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Aug 1, 2024
Comment on lines
57
to
+58
| CertifierInfoCacheTTL: 5 * time.Minute, | ||
| PowParamsCacheTTL: 5 * time.Minute, |
There was a problem hiding this comment.
Would it make sense to make this just one parameter instead of 2?
There was a problem hiding this comment.
Maybe 🤷. Giving extra flexibility doesn't hurt and it is useful in systests where certifier doesn't change at all (and can be cached for long time) but the pow_params change every epoch (1 minute)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6199 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 301 301
Lines 32406 32426 +20
=========================================
+ Hits 26548 26555 +7
- Misses 4135 4146 +11
- Partials 1723 1725 +2 ☔ View full report in Codecov by Sentry. |
poszu
changed the title
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
## Motivation Similarly to /v1/info, we query /v1/pow_params very often (once per submit per node ID). As the contents returned from this endpoint change rarely (once per epoch), it makes sense to cache the result.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
poszu
added a commit
that referenced
this pull request
Aug 1, 2024
## Motivation Similarly to /v1/info, we query /v1/pow_params very often (once per submit per node ID). As the contents returned from this endpoint change rarely (once per epoch), it makes sense to cache the result.
fasmat
pushed a commit
that referenced
this pull request
Aug 1, 2024
* configure poet /v1/info cache ttl in presets (#6198) ## Motivation For the cache to work, it needs to have non-zero TTL set * cache poet's /v1/pow_params with TTL (#6199) ## Motivation Similarly to /v1/info, we query /v1/pow_params very often (once per submit per node ID). As the contents returned from this endpoint change rarely (once per epoch), it makes sense to cache the result. * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similarly to /v1/info, we query /v1/pow_params very often (once per submit per node ID). As the contents returned from this endpoint change rarely (once per epoch), it makes sense to cache the result.
Description
cachedData structTest Plan
added a test, will also test on testnet-13 where we observe lots of requests to /v1/pow_params on 1:n nodes.
TODO