[Merged by Bors] - Remove scan malfeasant flag #6229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
approved these changes
Aug 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6229 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 309 308 -1
Lines 34120 34065 -55
=========================================
- Hits 28015 27968 -47
+ Misses 4328 4325 -3
+ Partials 1777 1772 -5 ☔ View full report in Codecov by Sentry. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Motivation This command line option was added during the last release to allow a node to scan its state during startup for the then newly introduced InvalidPreviousATX malfeasance proof. Since then all existing ATXs that are invalid have been marked as such and all nodes check newly incoming ATXs directly for their validity. So this isn't needed any more.
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Motivation This command line option was added during the last release to allow a node to scan its state during startup for the then newly introduced InvalidPreviousATX malfeasance proof. Since then all existing ATXs that are invalid have been marked as such and all nodes check newly incoming ATXs directly for their validity. So this isn't needed any more.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Motivation This command line option was added during the last release to allow a node to scan its state during startup for the then newly introduced InvalidPreviousATX malfeasance proof. Since then all existing ATXs that are invalid have been marked as such and all nodes check newly incoming ATXs directly for their validity. So this isn't needed any more.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This command line option was added during the last release to allow a node to scan its state during startup for the then newly introduced InvalidPreviousATX malfeasance proof.
Since then all existing ATXs that are invalid have been marked as such and all nodes check newly incoming ATXs directly for their validity. So this isn't needed any more.
Description
Remove code and tests that allows node to scan its state for invalid ATXs during startup.
Test Plan
n/a
TODO