Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - use zap in sql/metrics #6238

Closed
wants to merge 1 commit into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Aug 9, 2024

Motivation

Part of the effort to migrate to zap.

Description

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.1%. Comparing base (88ba729) to head (1025e2b).
Report is 1 commits behind head on develop.

Files Patch % Lines
sql/metrics/prometheus.go 0.0% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6238     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.1%     
=========================================
  Files          308     308             
  Lines        34066   34067      +1     
=========================================
  Hits         27976   27976             
- Misses        4314    4318      +4     
+ Partials      1776    1773      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu
Copy link
Contributor Author

poszu commented Aug 9, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 9, 2024
## Motivation

Part of the effort to migrate to zap.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 9, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title use zap in sql/metrics [Merged by Bors] - use zap in sql/metrics Aug 9, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 9, 2024
@spacemesh-bors spacemesh-bors bot deleted the refactor/use-zap-in-sql/metrics branch August 9, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants