[Merged by Bors] - chore: remove dependency on activation/wire from tests outside activation
#6244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
no-wire-dependency-sql
branch
from
5f84369 to
f0b477f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6244 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 308 308
Lines 34131 34117 -14
=========================================
- Hits 28017 27996 -21
- Misses 4339 4345 +6
- Partials 1775 1776 +1 ☔ View full report in Codecov by Sentry. |
fasmat
changed the title
activation/wire from tests outside activation
poszu
approved these changes
Aug 13, 2024
|
bors merge |
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ivation` (#6244) ## Motivation Most packages should be unaware of wire types and not depend on packages implementing them (including tests). This removes the dependency on `activation/wire` from most other packages.
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ivation` (#6244) ## Motivation Most packages should be unaware of wire types and not depend on packages implementing them (including tests). This removes the dependency on `activation/wire` from most other packages.
|
Build failed: |
poszu
approved these changes
Aug 13, 2024
|
bors merge |
|
Merge conflict. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ivation` (#6244) ## Motivation Most packages should be unaware of wire types and not depend on packages implementing them (including tests). This removes the dependency on `activation/wire` from most other packages.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
activation/wire from tests outside activationactivation/wire from tests outside activation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most packages should be unaware of wire types and not depend on packages implementing them (including tests).
This removes the dependency on
activation/wirefrom most other packages.Description
The actual bytes that are stored don't matter for most tests and even before the change didn't match the domain object thats persisted in some tests. This just removes the dependency and uses random bytes instead.
NOTE: The
checkpointpackage still uses wire types and in my opinion shouldn't. But to get rid of that dependency we would need to storeprevATXandposATXin the DB so we don't have to decode them from the stored blob.Test Plan
TODO