-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Cleanup code and changelog #6251
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6251 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 308 308
Lines 34131 34135 +4
=========================================
- Hits 28017 28014 -3
- Misses 4339 4345 +6
- Partials 1775 1776 +1 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
Aug 13, 2024
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Motivation This updates the changelog after the release of `v1.6.6-hotfix1` and fixes a few typos in code.
Build failed: |
bors merge |
Merge conflict. |
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Motivation This updates the changelog after the release of `v1.6.6-hotfix1` and fixes a few typos in code.
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Cleanup code and changelog
[Merged by Bors] - Cleanup code and changelog
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This updates the changelog after the release of
v1.6.6-hotfix1
and fixes a few typos in code.Description
activation/handler_v2.go
: simplified code to not having to query an identity again about its standingcheckMalfeasance
would return and then we would query again if it was found to be malicious, nowcheckMalfeasance
just returnstrue
if an identity is considered a bad actor.Test Plan
TODO