Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Cleanup code and changelog #6251

Closed
wants to merge 6 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 13, 2024

Motivation

This updates the changelog after the release of v1.6.6-hotfix1 and fixes a few typos in code.

Description

  • Updates CHANGELOG
  • all code changes are typo fixes except
  • activation/handler_v2.go: simplified code to not having to query an identity again about its standing
    • before if an identity was found to be malfeasant checkMalfeasance would return and then we would query again if it was found to be malicious, now checkMalfeasance just returns true if an identity is considered a bad actor.

Test Plan

  • existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 73.43750% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (d21910b) to head (e01bf14).

Files Patch % Lines
activation/handler_v2.go 60.4% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6251     +/-   ##
=========================================
- Coverage     82.0%   82.0%   -0.1%     
=========================================
  Files          308     308             
  Lines        34131   34135      +4     
=========================================
- Hits         28017   28014      -3     
- Misses        4339    4345      +6     
- Partials      1775    1776      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hare3/hare.go Outdated Show resolved Hide resolved
@fasmat
Copy link
Member Author

fasmat commented Aug 13, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 13, 2024
## Motivation

This updates the changelog after the release of `v1.6.6-hotfix1` and fixes a few typos in code.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Aug 13, 2024

bors merge

@spacemesh-bors
Copy link

Merge conflict.

@fasmat
Copy link
Member Author

fasmat commented Aug 13, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 13, 2024
## Motivation

This updates the changelog after the release of `v1.6.6-hotfix1` and fixes a few typos in code.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Cleanup code and changelog [Merged by Bors] - Cleanup code and changelog Aug 13, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 13, 2024
@spacemesh-bors spacemesh-bors bot deleted the cleanup-code-and-changelog branch August 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants