-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Avoid global logger in events #6258
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6258 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 308 307 -1
Lines 34087 34095 +8
=========================================
- Hits 27992 27978 -14
- Misses 4326 4336 +10
- Partials 1769 1781 +12 ☔ View full report in Codecov by Sentry. |
bors merge |
## Motivation Follow up to this discussion: #6252 (comment) Removal of the global logger from (most of) the event package.
Build failed: |
flaky test: #6113 bors merge |
## Motivation Follow up to this discussion: #6252 (comment) Removal of the global logger from (most of) the event package.
Pull request successfully merged into develop. Build succeeded: |
Motivation
Follow up to this discussion: #6252 (comment)
Removal of the global logger from (most of) the event package.
Description
This removes the global logger from most of the
reporter.go
file and removes a few other usages of thelog
package that are not needed any more.Test Plan
TODO