[Merged by Bors] - Upgrade go-libp2p to v0.37.2 #6497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, upgrade go-libp2p-kad-dht to v0.28.1 and quic-go to v0.48.2. There's a bug in go-libp2p related to reuse of the slices retured by `AddrsFactory`, fix: libp2p/go-libp2p#3068 For now, the problem is mitigated by cloning the slice returned from `AddrsFactory` (`cfg.AdvertiseAddress`). Deprecated `max-reservations-per-peer` field in the relay server config, as now it is always 1 (and other values didn't make too much sense).
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud and
jellonek
as code owners
|
Marking it as a draft to give it a bit more testing before we merge it. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6497 +/- ##
=========================================
Coverage ? 79.9%
=========================================
Files ? 352
Lines ? 46441
Branches ? 0
=========================================
Hits ? 37131
Misses ? 7207
Partials ? 2103 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild succeeded: |
|
P2P appears to work fine |
fasmat
approved these changes
Nov 27, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## Motivation Need to switch to a more up-do-date go-libp2p version.
|
Build failed (retrying...):
|
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
## Motivation Need to switch to a more up-do-date go-libp2p version.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
poszu
pushed a commit
that referenced
this pull request
Dec 5, 2024
## Motivation Need to switch to a more up-do-date go-libp2p version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Need to switch to a more up-do-date go-libp2p version.
Description
Also, upgrade go-libp2p-kad-dht to v0.28.1 and quic-go to v0.48.2.
There's a bug in go-libp2p related to reuse of the slices retured by
AddrsFactory, fix: libp2p/go-libp2p#3068For now, the problem is mitigated by cloning the slice returned from
AddrsFactory(cfg.AdvertiseAddress).Deprecated
max-reservations-per-peerfield in the relay server config, as now it is always 1 (and other values didn't make too much sense).Test Plan
Verify on mainnet / testnet nodes
TODO