Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-split] Extend systest with option to add split node setup #6522

Draft
wants to merge 1 commit into
base: node-split-poc
Choose a base branch
from

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Dec 5, 2024

This commit can be used as a testing platform for changes provided in #6521.

Note: split node setup will always deploy non smeshing node (node-service, pod named as smesher-X wher X is the biggest number) to which there will be deployed connected n-1 smeshing/client nodes (node-client, pods named activation-X). Because of that - node-split-size has to be set to 0 (default value) or >1.

On makefile or make run level that's controlled by setting e.g. node_split_size=3.

Extracted from #6506.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (49bbb0b) to head (d4a8ce9).
Report is 1 commits behind head on node-split-poc.

Files with missing lines Patch % Lines
api/node/server/server.go 0.0% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           node-split-poc   #6522     +/-   ##
================================================
- Coverage            77.2%   77.1%   -0.1%     
================================================
  Files                 342     342             
  Lines               45839   45844      +5     
================================================
  Hits                35391   35391             
- Misses               8330    8342     +12     
+ Partials             2118    2111      -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jellonek jellonek force-pushed the nodesplit/systestasutil branch from 69979cf to 81464dd Compare December 11, 2024 09:14
Note: split node setup will always deploy non smeshing node
to which there will be deployed connected n-1 activation nodes.
Because of that - node-split-size has to be set to 0 or >1.
@jellonek jellonek force-pushed the nodesplit/systestasutil branch from 81464dd to d4a8ce9 Compare December 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant