Skip to content

Commit

Permalink
improve margin in expansion panels in plugins (#2540)
Browse files Browse the repository at this point in the history
to prevent the negative margin imposed on the plugin content itself
  • Loading branch information
kecnry authored Oct 27, 2023
1 parent 7855702 commit 4178d8a
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 12 deletions.
6 changes: 6 additions & 0 deletions jdaviz/app.vue
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ div.output_wrapper {
padding: 0px;
}
.plugin-expansion-panel-content .row {
/* override -12px margins */
margin-left: 0px;
margin-right: 0px;
}
.glue__subset-select {
display: flex;
align-items: center;
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/cubeviz/plugins/slice/slice.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Indicator Settings</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row>
<v-switch
label="Show Indicator"
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/default/plugins/export_plot/export_plot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Export to Video</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row v-if="movie_msg!==''">
<span class="v-messages v-messages__message text--secondary" style="color: red !important">
{{ movie_msg }}
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/default/plugins/line_lists/line_lists.vue
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@

</v-row>
</v-expansion-panel-header>
<v-expansion-panel-content style="padding-left: 0px">
<v-expansion-panel-content class="plugin-expansion-panel-content">

<div v-if="item == 'Custom'" style="padding-top: 16px">
<v-row class="row-min-bottom-padding" style="display: block">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
</v-col>
</v-row>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row v-if="!item.compat_display_units">
<v-alert :type="componentInEquation(item.id) ? 'error' : 'warning'">
<b>{{ item.id }}</b> is inconsistent with the current display units so cannot be used in the model equation.
Expand Down
4 changes: 2 additions & 2 deletions jdaviz/configs/default/plugins/plot_options/plot_options.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Settings</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row>
<v-switch
v-model="show_viewer_labels"
Expand Down Expand Up @@ -374,7 +374,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">More Stretch Options</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row>
<v-text-field
ref="stretch_hist_nbins"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<v-expansion-panel-header >
<span style="padding: 6px">Recenter</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<plugin-dataset-select
:items="dataset_items"
:selected.sync="dataset_selected"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Settings</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<v-row>
<v-switch
v-model="interactive_extract"
Expand Down Expand Up @@ -167,7 +167,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Export Trace</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<plugin-add-results
:label.sync="trace_results_label"
:label_default="trace_results_label_default"
Expand Down Expand Up @@ -281,7 +281,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Export Background Image</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<plugin-add-results
:label.sync="bg_results_label"
:label_default="bg_results_label_default"
Expand All @@ -305,7 +305,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Export Background Spectrum</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<plugin-add-results
:label.sync="bg_spec_results_label"
:label_default="bg_spec_results_label_default"
Expand All @@ -329,7 +329,7 @@
<v-expansion-panel-header v-slot="{ open }">
<span style="padding: 6px">Export Background-Subtracted Image</span>
</v-expansion-panel-header>
<v-expansion-panel-content>
<v-expansion-panel-content class="plugin-expansion-panel-content">
<plugin-add-results
:label.sync="bg_sub_results_label"
:label_default="bg_sub_results_label_default"
Expand Down

0 comments on commit 4178d8a

Please sign in to comment.