Skip to content

Commit

Permalink
remove set_as_orientation kwarg
Browse files Browse the repository at this point in the history
  • Loading branch information
kecnry committed Nov 25, 2024
1 parent ce21a02 commit e2a853f
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions jdaviz/configs/imviz/plugins/orientation/orientation.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,8 +545,7 @@ def _set_north_up_east_left(self, label="North-up, East-left", set_as_orientatio
elif set_as_orientation:
self.orientation.selected = label

def set_north_up_east_left(self, label="North-up, East-left",
set_as_orientation=True):
def set_north_up_east_left(self, label="North-up, East-left"):
"""
Set (and create if necessary) the rotation angle and flip to achieve North up
and East left according to the reference image WCS.
Expand All @@ -557,11 +556,8 @@ def set_north_up_east_left(self, label="North-up, East-left",
Data label for the orientation layer. If already exists, will be set as the
current orientation layer according to ``set_as_orientation``. Otherwise,
a new layer will be created with this label.
set_as_orientation : bool
Whether to set as the current orientation. If False, the new layer will still
be created and available for selection, but will not be set as the current orientation.
"""
self._set_north_up_east_left(label=label, set_as_orientation=set_as_orientation)
self._set_north_up_east_left(label=label, set_as_orientation=True)

def _set_north_up_east_right(self, label="North-up, East-right", set_as_orientation=False,
from_ui=False):
Expand All @@ -573,8 +569,7 @@ def _set_north_up_east_right(self, label="North-up, East-right", set_as_orientat
elif set_as_orientation:
self.orientation.selected = label

def set_north_up_east_right(self, label="North-up, East-right",
set_as_orientation=True):
def set_north_up_east_right(self, label="North-up, East-right"):
"""
Set (and create, if necessary) the rotation angle and flip to achieve North up
and East right according to the reference image WCS.
Expand All @@ -585,11 +580,8 @@ def set_north_up_east_right(self, label="North-up, East-right",
Data label for the orientation layer. If already exists, will be set as the
current orientation layer according to ``set_as_orientation``. Otherwise,
a new layer will be created with this label.
set_as_orientation : bool
Whether to set as the current orientation. If False, the new layer will still
be created and available for selection, but will not be set as the current orientation.
"""
self._set_north_up_east_right(label=label, set_as_orientation=set_as_orientation)
self._set_north_up_east_right(label=label, set_as_orientation=True)

def vue_select_north_up_east_left(self, *args, **kwargs):
self._set_north_up_east_left(set_as_orientation=True, from_ui=True)
Expand Down

0 comments on commit e2a853f

Please sign in to comment.