Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable stretch histogram in 2d spectrum viewers #2407

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 30, 2023

Description

This pull request includes the stretch histogram (in plot options) in 2d spectrum viewers in specviz2d and mosviz, and fixes a bug related to handling zoom-limits when the x-axis is inverted (caused by linking between pixels and the spectral axis in the 1d spectrum viewer).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.7 milestone Aug 30, 2023
@kecnry kecnry force-pushed the stretch-hist-spec2d branch from b399a87 to 0906ada Compare August 30, 2023 17:20
@kecnry kecnry marked this pull request as ready for review August 30, 2023 17:31
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage is 57.57% of modified lines.

Files Changed Coverage
...nfigs/default/plugins/plot_options/plot_options.py 57.57%

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kecnry kecnry force-pushed the stretch-hist-spec2d branch from 0906ada to 4ef862d Compare August 31, 2023 15:29
Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally on Mosviz and Specviz2D. Looks good to me!

@kecnry kecnry merged commit 1577249 into spacetelescope:main Sep 1, 2023
11 of 14 checks passed
@kecnry kecnry deleted the stretch-hist-spec2d branch September 1, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants