Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle ping without timestamp #2411

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Aug 31, 2023

Description

This pull request handles the case of multiple tracebacks raised by the ping infrastructure when a popout window sends the ping, but without the timestamp in the payload. It handles this case by assuming the received time as the ping timestamp.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working 💤 backport-v3.6.x on-merge: backport to v3.6.x labels Aug 31, 2023
@kecnry kecnry added this to the 3.6.3 milestone Aug 31, 2023
@kecnry kecnry force-pushed the fix-ping-without-time branch from ce23950 to baa1108 Compare August 31, 2023 15:36
@kecnry kecnry marked this pull request as ready for review August 31, 2023 15:48
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Not sure if we have other choice here when it sends no info. Thanks!

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage is 44.82% of modified lines.

Files Changed Coverage
jdaviz/core/template_mixin.py 0.00%
...nfigs/default/plugins/plot_options/plot_options.py 48.14%

📢 Thoughts on this report? Let us know!.

@camipacifici
Copy link
Contributor

I do not see the warnings anymore! Thank you

@kecnry kecnry merged commit f2e45c6 into spacetelescope:main Aug 31, 2023
15 of 18 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Aug 31, 2023
@kecnry kecnry deleted the fix-ping-without-time branch August 31, 2023 16:36
kecnry added a commit that referenced this pull request Aug 31, 2023
…1-on-v3.6.x

Backport PR #2411 on branch v3.6.x (handle ping without timestamp)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for final review 💤 backport-v3.6.x on-merge: backport to v3.6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants