-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix footprint defaults when changing traitlets before plugin active #2413
fix footprint defaults when changing traitlets before plugin active #2413
Conversation
* for the FIRST overlay, the user could have set the color traitlet before the internal overlay object is created (which occurs as soon as the plugin is first shown). In that case, we want to respect the user choice of color.
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes the problem, thank you! |
Setting back to draft while I look into the issue of overwriting an existing regions object (that used to work - there is a chance this broke that, so I want to make sure it didn't and make sure we have test coverage for that case). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the bug as described, thanks!
* along with regression testing
Description
This pull request fixes respecting user-changed traitlets (specifically color, but also applies to the preset selection) when those traitlets were set in the API before the overlay objects are fully initialized when the plugin is first opened.
See the included regression test or the following example:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.