Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump standalone workflow versions #2444

Closed
wants to merge 4 commits into from
Closed

Bump standalone workflow versions #2444

wants to merge 4 commits into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 11, 2023

Description

This pull request is to use the debug branch to see if my patch would work. Also includes #2443 for that one workflow.

If things work, I will open a proper PR from fork for #2442 .

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Sep 11, 2023
@pllim pllim added this to the 3.7 milestone Sep 11, 2023
@pllim
Copy link
Contributor Author

pllim commented Sep 11, 2023

@rosteen , how do I make the standalone build happen here?

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@pllim
Copy link
Contributor Author

pllim commented Sep 12, 2023

This isn't the way.

Also I am going to reset the branch to sync with main. I dunno why there are 3 extra commits.

@pllim pllim closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants